[webkit-changes] [WebKit/WebKit] aceba5: [ATSPI] Make `Atspi::State` an enum class

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aceba59eaf385568950ba93c6c779a5aebe95a8f
      https://github.com/WebKit/WebKit/commit/aceba59eaf385568950ba93c6c779a5aebe95a8f
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2023-01-13 (Fri, 13 Jan 2023)

  Changed paths:
    M Source/WebCore/accessibility/atspi/AccessibilityAtspiEnums.h
    M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
    M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h
    M Source/WebCore/accessibility/atspi/AccessibilityObjectCollectionAtspi.cpp
    M Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp

  Log Message:
  -----------
  [ATSPI] Make `Atspi::State` an enum class
https://bugs.webkit.org/show_bug.cgi?id=250564

Reviewed by Michael Catanzaro.

This patch makes `Atpsi::State` an enum class and changes the signature
of `uint64_t AccessibilityObjectAtspi::state() const` to
`OptionSet<Atspi::State> AccessibilityObjectAtspi::states() const`.

It makes it easier to work with states and improves code readability.
Instead of using bitwise operations, we can now use `OptionSet`s methods,
such as `add()`, `contains()`, `containsAll()`, and `containsAny()`.

* Source/WebCore/accessibility/atspi/AccessibilityAtspiEnums.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::states const):
(WebCore::AccessibilityObjectAtspi::buildStates const):
(WebCore::AccessibilityObjectAtspi::serialize const):
(WebCore::AccessibilityObjectAtspi::state const): Deleted.
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectCollectionAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::CollectionMatchRule::CollectionMatchRule):
(WebCore::AccessibilityObjectAtspi::CollectionMatchRule::matchStates):
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::checkElementState):

Canonical link: https://commits.webkit.org/258890@main