[webkit-changes] [WebKit/WebKit] dffcbb: Make FilterOperation::OperationType an enum class

Antoine Quint noreply at github.com
Thu Jan 12 22:26:38 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dffcbbe951fc5f5f777fb0279e4cc43b7823d617
      https://github.com/WebKit/WebKit/commit/dffcbbe951fc5f5f777fb0279e4cc43b7823d617
  Author: Antoine Quint <graouts at apple.com>
  Date:   2023-01-12 (Thu, 12 Jan 2023)

  Changed paths:
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/editing/ReplaceSelectionCommand.cpp
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
    M Source/WebCore/platform/graphics/ca/PlatformCAFilters.h
    M Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm
    M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
    M Source/WebCore/platform/graphics/ca/win/PlatformCAFiltersWin.cpp
    M Source/WebCore/platform/graphics/filters/FilterOperation.cpp
    M Source/WebCore/platform/graphics/filters/FilterOperation.h
    M Source/WebCore/platform/graphics/filters/FilterOperations.cpp
    M Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp
    M Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
    M Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
    M Source/WebCore/rendering/CSSFilter.cpp
    M Source/WebCore/rendering/ReferencedSVGResources.cpp
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
    M Source/WebCore/rendering/svg/SVGResources.cpp
    M Source/WebCore/style/FilterOperationsBuilder.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
    M Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp

  Log Message:
  -----------
  Make FilterOperation::OperationType an enum class
https://bugs.webkit.org/show_bug.cgi?id=250519

Reviewed by Alex Christensen.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForFilter):
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
(WebCore::fragmentNeedsColorTransformed):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
* Source/WebCore/platform/graphics/ca/PlatformCAFilters.h:
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
(WebCore::PlatformCAFilters::setFiltersOnLayer):
(WebCore::PlatformCAFilters::filterValueForOperation):
(WebCore::PlatformCAFilters::colorMatrixValueForFilter):
(WebCore::PlatformCAFilters::isAnimatedFilterProperty):
(WebCore::PlatformCAFilters::animatedFilterPropertyName):
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::filtersCanBeComposited):
* Source/WebCore/platform/graphics/ca/win/PlatformCAFiltersWin.cpp:
(PlatformCAFilters::isAnimatedFilterProperty):
(PlatformCAFilters::animatedFilterPropertyName):
* Source/WebCore/platform/graphics/filters/FilterOperation.cpp:
(WebCore::DefaultFilterOperation::representedType const):
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
(WebCore::FilterOperation::blendAmounts const):
(WebCore::BasicColorMatrixFilterOperation::isIdentity const):
(WebCore::BasicColorMatrixFilterOperation::transformColor const):
(WebCore::BasicColorMatrixFilterOperation::passthroughAmount const):
(WebCore::BasicComponentTransferFilterOperation::isIdentity const):
(WebCore::BasicComponentTransferFilterOperation::transformColor const):
(WebCore::BasicComponentTransferFilterOperation::passthroughAmount const):
(WebCore::BasicComponentTransferFilterOperation::affectsOpacity const):
(WebCore::operator<<):
* Source/WebCore/platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::type const):
(WebCore::FilterOperation::isBasicColorMatrixFilterOperation const):
(WebCore::FilterOperation::isBasicComponentTransferFilterOperation const):
(WebCore::FilterOperation::FilterOperation):
(WebCore::PassthroughFilterOperation::PassthroughFilterOperation):
* Source/WebCore/platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::hasReferenceFilter const):
(WebCore::FilterOperations::outsets const):
* Source/WebCore/platform/graphics/texmap/BitmapTextureGL.cpp:
(WebCore::getPassesRequiredForFilter):
(WebCore::BitmapTextureGL::applyFilters):
* Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::filtersCanBeComposited const):
* Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::optionsForFilterType):
(WebCore::prepareFilterProgram):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::filtersCanBeComposited const):
(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
* Source/WebCore/rendering/CSSFilter.cpp:
(WebCore::CSSFilter::buildFilterFunctions):
(WebCore::CSSFilter::isIdentity):
(WebCore::CSSFilter::calculateOutsets):
* Source/WebCore/rendering/ReferencedSVGResources.cpp:
(WebCore::ReferencedSVGResources::referencedSVGResourceIDs):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::hasReferenceFilterOnly const):
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeResources):
* Source/WebCore/rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::buildCachedResources):
* Source/WebCore/style/FilterOperationsBuilder.cpp:
(WebCore::Style::filterOperationForType):
(WebCore::Style::createFilterOperations):
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<FilterOperation>::encode):
(IPC::decodeFilterOperation):
* Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp:
(WebKit::filtersCanBeComposited):

Canonical link: https://commits.webkit.org/258864@main




More information about the webkit-changes mailing list