[webkit-changes] [WebKit/WebKit] 2a6683: Start extracting common WARNING_CFLAGS into Common...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2a6683c96f6be3ce8e348678b776b9b89844547a
      https://github.com/WebKit/WebKit/commit/2a6683c96f6be3ce8e348678b776b9b89844547a
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-01-12 (Thu, 12 Jan 2023)

  Changed paths:
    M Configurations/CommonBase.xcconfig
    M Source/JavaScriptCore/Configurations/Base.xcconfig
    M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
    M Source/ThirdParty/ANGLE/Configurations/Base.xcconfig
    M Source/ThirdParty/gtest/xcode/Config/General.xcconfig
    M Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig
    M Source/WTF/Configurations/Base.xcconfig
    M Source/WebCore/Configurations/Base.xcconfig
    M Source/WebCore/PAL/Configurations/Base.xcconfig
    M Source/WebCore/PAL/ThirdParty/libavif/Configurations/Base.xcconfig
    M Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/Base.xcconfig
    M Source/WebGPU/Configurations/Base.xcconfig
    M Source/WebInspectorUI/Configurations/Base.xcconfig
    M Source/WebKit/Configurations/Base.xcconfig
    M Source/WebKitLegacy/mac/Configurations/Base.xcconfig
    M Source/bmalloc/Configurations/Base.xcconfig
    M Tools/DumpRenderTree/mac/Configurations/Base.xcconfig
    M Tools/ImageDiff/cg/Configurations/Base.xcconfig
    M Tools/MiniBrowser/Configurations/Base.xcconfig
    M Tools/MobileMiniBrowser/Configurations/Base.xcconfig
    M Tools/TestWebKitAPI/Configurations/Base.xcconfig
    M Tools/WebEditingTester/Configurations/Base.xcconfig
    M Tools/WebKitTestRunner/Configurations/Base.xcconfig
    M Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig

  Log Message:
  -----------
  Start extracting common WARNING_CFLAGS into CommonBase.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=250431
<rdar://104102992>

Reviewed by Alex Christensen.

Extract common WARNING_CFLAGS into CommonBase.xcconfig into the
WK_COMMON_WARNING_CFLAGS Xcode variable.  The following warnings
are also removed:
  -W: Same as -Wextra.
  -Wmissing-format-attribute: No effect in clang (gcc compat).

Some projects also add WK_FIXME_WARNING_CFLAGS to document and
to disable pre-existing warnings that weren't previously known
because some warning flags were not enabled on some projects.

* Configurations/CommonBase.xcconfig:
(WK_COMMON_WARNING_CFLAGS): Add.
- Start list of common warning flags among all projects.
* Source/JavaScriptCore/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
* Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:
(ANGLE (Dynamic)):
- Remove `GCC_TREAT_WARNINGS_AS_ERRORS = NO` from Debug, Release
  and Production configurations.  Regressed in 244928 at main.
* Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Source/ThirdParty/gtest/xcode/Config/General.xcconfig:
(GCC_TREAT_WARNINGS_AS_ERRORS): Add.  Use instead of -Werror.
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Source/WTF/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
* Source/WebCore/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
* Source/WebCore/PAL/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
* Source/WebCore/PAL/ThirdParty/libavif/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
* Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
* Source/WebGPU/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
* Source/WebInspectorUI/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Source/WebKit/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Source/bmalloc/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
* Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Tools/ImageDiff/cg/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Tools/MiniBrowser/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Tools/MobileMiniBrowser/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Tools/TestWebKitAPI/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Tools/WebEditingTester/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Tools/WebKitTestRunner/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.
* Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig:
(WARNING_CFLAGS):
(WK_FIXME_WARNING_CFLAGS): Add.

Canonical link: https://commits.webkit.org/258855@main