[webkit-changes] [WebKit/WebKit] 88766c: AX: Remove obsolete comment in AXIsolatedTree::upd...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88766c1ad26bf12c2bb3e4fca52d2390385dfca8
      https://github.com/WebKit/WebKit/commit/88766c1ad26bf12c2bb3e4fca52d2390385dfca8
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-01-12 (Thu, 12 Jan 2023)

  Changed paths:
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  -----------
  AX: Remove obsolete comment in AXIsolatedTree::updateChildren regarding subtree removals
https://bugs.webkit.org/show_bug.cgi?id=250503
rdar://problem/104156450

Reviewed by Chris Fleizach.

This comment in AXIsolatedTree::updateChildren regarding subtree removal behavior was obsoleted by this commit:

https://github.com/WebKit/WebKit/commit/755fc266ed7bbbbcd5505c9e842d89caf9796c19

Because the referenced variable (idsBeingChanged) was obsoleted by checking m_unresolvedPendingAppends in
AXIsolatedTree::removeSubtreeFromNodeMap (which accomplishes the same thing).

Also, move the objectID().isValid() check performed before calling removeSubtreeFromNodeMap to removeSubtreeFromNodeMap itself.
This makes AXIsolatedTree::updateChildren less dense, and improves the logging generated by removeSubtreeFromNodeMap
as it will no longer log "Tried to remove AXID 0 that is no longer in m_nodeMap." for invalid IDs.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildren):
(WebCore::AXIsolatedTree::removeSubtreeFromNodeMap):

Canonical link: https://commits.webkit.org/258839@main