[webkit-changes] [WebKit/WebKit] 01a818: [Cocoa] Encrypted media playback fails with "Conte...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 01a818734b82d674da0aff081efca013fc38660e
      https://github.com/WebKit/WebKit/commit/01a818734b82d674da0aff081efca013fc38660e
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-01-12 (Thu, 12 Jan 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

  Log Message:
  -----------
  [Cocoa] Encrypted media playback fails with "ContentKey support for SampleBuffer Renderers" enabled
https://bugs.webkit.org/show_bug.cgi?id=250473
rdar://104044401

Reviewed by Eric Carlson.

When this feature is enabled, decryption information is no longer attached at parse time, and instead
needs to be attached at display time. However VTDecompressionSession cannot be used along with
AVContentKeySession, and no frames are emitted from the session. This leads to a failure to seek, since
the seek operation cannot complete until there is an image to display for the new current time.

When a CDMInstance is attached to the MediaPlayer, reconsider whether to create a AVSBDL or a decompression
session, and always create the layer if there is a valid instance attached.

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayer const):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceDetached):

Canonical link: https://commits.webkit.org/258837@main