[webkit-changes] [WebKit/WebKit] 4dde2b: REGRESSION (Safari 14-16): Duplicated CR-LF in tex...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4dde2b983f435bf53bac935b211ad81ec9a95ea2
      https://github.com/WebKit/WebKit/commit/4dde2b983f435bf53bac935b211ad81ec9a95ea2
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-12 (Thu, 12 Jan 2023)

  Changed paths:
    A LayoutTests/fast/forms/wrap-hard-incorrect-submit-form-data-expected.txt
    A LayoutTests/fast/forms/wrap-hard-incorrect-submit-form-data.html
    M Source/WebCore/html/HTMLTextFormControlElement.cpp

  Log Message:
  -----------
  REGRESSION (Safari 14-16): Duplicated CR-LF in textarea with wrap="hard"
https://bugs.webkit.org/show_bug.cgi?id=249923
<rdar://problem/103870498>

Reviewed by Antti Koivisto.

This was caused by a slight confusion of when legacy line layout sets "endsWithBreak" on a line.
While initially this bit was introduced for <br> (previousLineBrokeAtBR), over time it
turned into a "any type of line break" bit.
skipToNextSoftLineBreakPosition now checks for "any line break" and also ignores the last line.

* Source/WebCore/html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks const):

Canonical link: https://commits.webkit.org/258830@main