[webkit-changes] [WebKit/WebKit] 3d4e47: Gamepad.vibrationActuator should be nullable

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d4e479d3a85a13944f8ebabf3dd912fdfab7a47
      https://github.com/WebKit/WebKit/commit/3d4e479d3a85a13944f8ebabf3dd912fdfab7a47
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-01-11 (Wed, 11 Jan 2023)

  Changed paths:
    M LayoutTests/gamepad/gamepad-event-handlers.html
    M LayoutTests/gamepad/gamepad-polling-access.html
    M LayoutTests/gamepad/gamepad-timestamp.html
    M LayoutTests/gamepad/gamepad-vibration-document-no-longer-fully-active.html
    M LayoutTests/gamepad/gamepad-vibration-visibility-change.html
    M LayoutTests/gamepad/gamepad-vibrationActuator-SameObject.html
    A LayoutTests/gamepad/gamepad-vibrationActuator-nullable-expected.txt
    A LayoutTests/gamepad/gamepad-vibrationActuator-nullable.html
    M LayoutTests/gamepad/gamepad-vibrationActuator-playEffect-validation.html
    M LayoutTests/gamepad/gamepad-vibrationActuator-type.html
    M LayoutTests/gamepad/gamepad-visibility-1.html
    M Source/WebCore/Modules/gamepad/Gamepad.cpp
    M Source/WebCore/Modules/gamepad/Gamepad.h
    M Source/WebCore/Modules/gamepad/Gamepad.idl
    M Source/WebCore/testing/MockGamepad.cpp
    M Source/WebCore/testing/MockGamepad.h
    M Source/WebCore/testing/MockGamepadProvider.cpp
    M Source/WebCore/testing/MockGamepadProvider.h
    M Source/WebCore/testing/js/WebCoreTestSupport.cpp
    M Source/WebCore/testing/js/WebCoreTestSupport.h
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  -----------
  Gamepad.vibrationActuator should be nullable
https://bugs.webkit.org/show_bug.cgi?id=250411

Reviewed by Brent Fulgham.

Gamepad.vibrationActuator should be nullable:
- https://github.com/w3c/gamepad/issues/178

Gamepad.vibrationActuator is supposed to return null if the gamepad doesn't support dual-rumble:
- https://w3c.github.io/gamepad/extensions.html#gamepadhapticactuator-interface (Construction section)

* LayoutTests/gamepad/gamepad-event-handlers.html:
* LayoutTests/gamepad/gamepad-polling-access.html:
* LayoutTests/gamepad/gamepad-timestamp.html:
* LayoutTests/gamepad/gamepad-vibrationActuator-SameObject.html:
* LayoutTests/gamepad/gamepad-vibrationActuator-nullable-expected.txt: Added.
* LayoutTests/gamepad/gamepad-vibrationActuator-nullable.html: Added.
* LayoutTests/gamepad/gamepad-vibrationActuator-playEffect-validation.html:
* LayoutTests/gamepad/gamepad-vibrationActuator-type.html:
* LayoutTests/gamepad/gamepad-visibility-1.html:
* Source/WebCore/Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::vibrationActuator): Deleted.
* Source/WebCore/Modules/gamepad/Gamepad.h:
* Source/WebCore/Modules/gamepad/Gamepad.idl:
* Source/WebCore/testing/MockGamepad.cpp:
(WebCore::MockGamepad::MockGamepad):
(WebCore::MockGamepad::updateDetails):
* Source/WebCore/testing/MockGamepad.h:
* Source/WebCore/testing/MockGamepadProvider.cpp:
(WebCore::MockGamepadProvider::setMockGamepadDetails):
* Source/WebCore/testing/MockGamepadProvider.h:
* Source/WebCore/testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::setMockGamepadDetails):
* Source/WebCore/testing/js/WebCoreTestSupport.h:
* Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setMockGamepadDetails):
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

Canonical link: https://commits.webkit.org/258812@main