[webkit-changes] [WebKit/WebKit] d185a0: Use ThreadSafeWeakPtr for m_parent in ScrollingTre...

Ryosuke Niwa noreply at github.com
Wed Jan 11 11:51:50 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d185a07dccbfd36d052f51b9bde0e42ddfc92d7f
      https://github.com/WebKit/WebKit/commit/d185a07dccbfd36d052f51b9bde0e42ddfc92d7f
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-01-11 (Wed, 11 Jan 2023)

  Changed paths:
    M Source/WebCore/page/scrolling/ScrollingTree.cpp
    M Source/WebCore/page/scrolling/ScrollingTreeFixedNode.cpp
    M Source/WebCore/page/scrolling/ScrollingTreeNode.cpp
    M Source/WebCore/page/scrolling/ScrollingTreeNode.h
    M Source/WebCore/page/scrolling/ScrollingTreeStickyNode.cpp

  Log Message:
  -----------
  Use ThreadSafeWeakPtr for m_parent in ScrollingTreeNode
https://bugs.webkit.org/show_bug.cgi?id=250447

Reviewed by Simon Fraser and Chris Dumez.

Use ThreadSafeWeakPtr to store the parent node in ScrollingTreeNode.

* Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::handleWheelEventWithNode):
(WebCore::ScrollingTree::updateTreeFromStateNodeRecursive):
* Source/WebCore/page/scrolling/ScrollingTreeFixedNode.cpp:
(WebCore::ScrollingTreeFixedNode::computeLayerPosition const):
* Source/WebCore/page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::enclosingFrameNodeIncludingSelf):
(WebCore::ScrollingTreeNode::enclosingScrollingNodeIncludingSelf):
* Source/WebCore/page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::parent const):
(WebCore::ScrollingTreeNode::setParent):
(): Deleted.
* Source/WebCore/page/scrolling/ScrollingTreeStickyNode.cpp:
(WebCore::ScrollingTreeStickyNode::computeLayerPosition const):

Canonical link: https://commits.webkit.org/258795@main




More information about the webkit-changes mailing list