[webkit-changes] [WebKit/WebKit] 46c1b7: [iOS] CSS transform transitions become janky after...

Antoine Quint noreply at github.com
Wed Jan 11 03:34:56 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46c1b789ed0879837b4cd085fbd48e0ad702366d
      https://github.com/WebKit/WebKit/commit/46c1b789ed0879837b4cd085fbd48e0ad702366d
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-01-11 (Wed, 11 Jan 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm

  Log Message:
  -----------
  [iOS] CSS transform transitions become janky after snapshotting other UIViews
https://bugs.webkit.org/show_bug.cgi?id=228333
rdar://81165591

Reviewed by Dean Jackson.

In WebKit clients that use the UIView snapshotting API, accelerated animations, which
are ran using Core Animation, will not run anymore. This happens because we use absolute
start times for our CAAnimation objects, and this does not play well with the UIView
snapshotting machinery.

Using the -[CALayer setInheritsTiming:(BOOL)] private API addresses this issue, so we call
it with NO any time we add a CAAnimation to a remote layer.

* Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:
(WebKit::addAnimationToLayer):

Canonical link: https://commits.webkit.org/258781@main




More information about the webkit-changes mailing list