[webkit-changes] [WebKit/WebKit] 63d1cc: [css-transition] ensure we fill transition-propert...

Antoine Quint noreply at github.com
Tue Jan 10 22:33:11 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63d1cc8d95c686a9d1684288f16112864aeb9908
      https://github.com/WebKit/WebKit/commit/63d1cc8d95c686a9d1684288f16112864aeb9908
  Author: Antoine Quint <graouts at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-mismatched-property-numbers-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-mismatched-property-numbers.html
    M Source/WebCore/platform/animation/Animation.cpp
    M Source/WebCore/platform/animation/Animation.h
    M Source/WebCore/platform/animation/AnimationList.cpp

  Log Message:
  -----------
  [css-transition] ensure we fill transition-property values with a custom property when other transition CSS properties are used with a longer list of items
https://bugs.webkit.org/show_bug.cgi?id=250401
rdar://104073160

Reviewed by Dean Jackson.

It's possible for certain CSS transition properties to specify a longer list of values than the
transition-property property itself. In the case where a custom property is used, we must ensure
to fill in the custom property string for the generated Animation object.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-mismatched-property-numbers-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-mismatched-property-numbers.html: Added.
* Source/WebCore/platform/animation/Animation.cpp:
(WebCore::Animation::Animation):
(WebCore::Animation::animationsMatch const):
* Source/WebCore/platform/animation/Animation.h:
(WebCore::Animation::isCustomOrUnknownPropertySet const):
(WebCore::Animation::isEmpty const):
(WebCore::Animation::clearCustomOrUnknownProperty):
(WebCore::Animation::clearAll):
(WebCore::Animation::setCustomOrUnknownProperty):
(WebCore::Animation::fillCustomOrUnknownProperty):
* Source/WebCore/platform/animation/AnimationList.cpp:
(WebCore::AnimationList::fillUnsetProperties):

Canonical link: https://commits.webkit.org/258770@main




More information about the webkit-changes mailing list