[webkit-changes] [WebKit/WebKit] fefa4f: Disable DOMParser's includeShadowRoots option by d...

Ryosuke Niwa noreply at github.com
Tue Jan 10 21:48:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fefa4f6d0b96e6ed774fd8103df98d8546ef24ec
      https://github.com/WebKit/WebKit/commit/fefa4f6d0b96e6ed774fd8103df98d8546ef24ec
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/html/parser/HTMLConstructionSite.cpp
    M Source/WebCore/html/parser/HTMLConstructionSite.h
    M Source/WebCore/html/parser/HTMLTreeBuilder.cpp
    M Source/WebCore/xml/DOMParser.cpp

  Log Message:
  -----------
  Disable DOMParser's includeShadowRoots option by default
https://bugs.webkit.org/show_bug.cgi?id=250421

Reviewed by Chris Dumez.

Add a new runtime flag to enable includeShadowRoots option in DOMParser
and turn this feature off by default.

Also deleted a runtime flag for streaming declarative shadow DOM
as we're only supporting streaming going forward.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLTemplateElement):
(WebCore::HTMLConstructionSite::attachDeclarativeShadowRootIfNeeded): Deleted.
* Source/WebCore/html/parser/HTMLConstructionSite.h:
* Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
* Source/WebCore/xml/DOMParser.cpp:
(WebCore::DOMParser::parseFromString):

Canonical link: https://commits.webkit.org/258768@main




More information about the webkit-changes mailing list