[webkit-changes] [WebKit/WebKit] a0f88c: [CSS-Typed-OM] Stop treating grid-row-start / grid...

Chris Dumez noreply at github.com
Tue Jan 10 19:15:40 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a0f88ce9701ec7264f02d2907fb2e0c33af89f1e
      https://github.com/WebKit/WebKit/commit/a0f88ce9701ec7264f02d2907fb2e0c33af89f1e
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-start-end-expected.txt
    M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp

  Log Message:
  -----------
  [CSS-Typed-OM] Stop treating grid-row-start / grid-column-start / grid-row-end / grid-column-end as list properties
https://bugs.webkit.org/show_bug.cgi?id=250044

Reviewed by Matt Woodrow.

Stop treating grid-row-start / grid-column-start / grid-row-end / grid-column-end
as list properties in the CSS Typed OM API. Our logic currently treats those as
list properties because the CSS Parser (consumeGridLine) generates a CSSValueList
to represent them.

Specification:
- https://w3c.github.io/csswg-drafts/css-grid/#typedef-grid-row-start-grid-line

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/grid-start-end-expected.txt:
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::mayConvertCSSValueListToSingleValue):
(WebCore::CSSStyleValueFactory::reifyValue):

Canonical link: https://commits.webkit.org/258764@main




More information about the webkit-changes mailing list