[webkit-changes] [WebKit/WebKit] 7d8a1c: Tests that change page scale still trigger <CATran...

Simon Fraser noreply at github.com
Tue Jan 10 15:06:49 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d8a1c4dc4abe02f0126ce632d3af17318e8aa20
      https://github.com/WebKit/WebKit/commit/7d8a1c4dc4abe02f0126ce632d3af17318e8aa20
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
    M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp

  Log Message:
  -----------
  Tests that change page scale still trigger <CATransformLayer> changing property contentsScale in transform-only layer, will have no effect" logging
https://bugs.webkit.org/show_bug.cgi?id=250344
rdar://104050312

Reviewed by Tim Horton.

There were still code paths that changed the `ContentsScaleChanged` property on PlatformCALayers wrapping a CATransformLayer,
triggering "<CATransformLayer> changing property contentsScale in transform-only layer".

So cut this off a bit lower down, by early returning from `setContentsScale()` functions on PlatformCALayer subclasses.

* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::initialize):
* Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::setContentsScale):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::setContentsScale):

Canonical link: https://commits.webkit.org/258745@main




More information about the webkit-changes mailing list