[webkit-changes] [WebKit/WebKit] fc1f99: Don't attempt to de-reference node in createSlider...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc1f99b860a5e09e532fb557a0fa4857531e35a1
      https://github.com/WebKit/WebKit/commit/fc1f99b860a5e09e532fb557a0fa4857531e35a1
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    A LayoutTests/fast/forms/slider-appearance-on-pseudo-element-expected.txt
    A LayoutTests/fast/forms/slider-appearance-on-pseudo-element.html
    M Source/WebCore/rendering/RenderTheme.cpp

  Log Message:
  -----------
  Don't attempt to de-reference node in createSliderTrackPartForRenderer
https://bugs.webkit.org/show_bug.cgi?id=250378
rdar://104072805

Reviewed by Aditya Keerthi.

The node may be null in case the renderer is associated to some pseudo-elements.

Happens on all pseudo-elements that support appearance (excludes ::marker), and that are not
backed by PseudoElement (excludes ::before/::after). So ::backdrop or ::-webkit-scrollbar both have null nodes.

The dereferencing is pretty unnecessary here, since dynamicDowncast returns a pointer anyway.

* LayoutTests/fast/forms/slider-appearance-on-pseudo-element-expected.txt: Added.
* LayoutTests/fast/forms/slider-appearance-on-pseudo-element.html: Added.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::createSliderTrackPartForRenderer):

Canonical link: https://commits.webkit.org/258739@main