[webkit-changes] [WebKit/WebKit] 3e90af: REGRESSION (257171 at main): Static media query insid...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3e90af4d3b3416f94d82753d2443692300907865
      https://github.com/WebKit/WebKit/commit/3e90af4d3b3416f94d82753d2443692300907865
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    A LayoutTests/fast/media/mq-nested-non-dynamic-expected.html
    A LayoutTests/fast/media/mq-nested-non-dynamic.html
    M Source/WebCore/style/RuleSetBuilder.cpp

  Log Message:
  -----------
  REGRESSION (257171 at main): Static media query inside a dynamic media query breaks dynamic evaluation
https://bugs.webkit.org/show_bug.cgi?id=250293
rdar://103732686

Reviewed by Simon Fraser.

Dynamic queries end up always matching.

* LayoutTests/fast/media/mq-nested-non-dynamic-expected.html: Added.
* LayoutTests/fast/media/mq-nested-non-dynamic.html: Added.
* Source/WebCore/style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::MediaQueryCollector::pop):

Take care we don't pop a wrong stack frame. Static queries don't add to the stack.

Canonical link: https://commits.webkit.org/258732@main