[webkit-changes] [WebKit/WebKit] 28de25: Change the default oblique angle from 20deg to 14deg

Ahmad Saleem noreply at github.com
Tue Jan 10 06:29:25 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 28de25b653f64ca3fc8e87fbf1d1a963329a5342
      https://github.com/WebKit/WebKit/commit/28de25b653f64ca3fc8e87fbf1d1a963329a5342
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M LayoutTests/fast/text/font-style-parse-expected.txt
    M LayoutTests/fast/text/font-style-parse.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-font-matching-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-style-parsing-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/resources/FontStyleTest-slnt-VF.woff2
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/resources/FontStyleTest-slnt_backslant-VF.woff2
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/platform/graphics/FontSelectionAlgorithm.h

  Log Message:
  -----------
  Change the default oblique angle from 20deg to 14deg

Change the default oblique angle from 20deg to 14deg
https://bugs.webkit.org/show_bug.cgi?id=248258

Reviewed by Myles C. Maxfield.

This patch is to align Webkit with Blink / Chromium, Gecko / Firefox and Web-Specification. This is also part of Interop 2023 proposal [1].

[1] https://github.com/web-platform-tests/interop/issues/64

Merge - https://chromium.googlesource.com/chromium/src/+/8bfd7d5770ec70f47e84b5cf33961b437a87c5a7

Web-Specification - http://w3c.github.io/csswg-drafts/css-fonts-4/#valdef-font-style-oblique-angle-90deg-90deg

The specs refer to have default angle as 14deg - "The lack of an <angle> represents 14deg.".

The imported test cases are leveraging font from Stephen Nixon using the Open Font License [2].

[2] https://github.com/arrowtype/vf-slnt-test/blob/main/fonts/license-recursive-OFL.txt#L3

* Source/WebCore/platform/graphics/FontSelectionAlgorithm.h: Update "italicThreshold" and "normalItalicValue" from 20deg to 14deg
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable.html: Added Test Case
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable-ref.html: Added Test Case Reference
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-variable-expected.html: Added Test Case Expectations
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable.html: Added Test Case
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable-ref.html: Added Test Case Reference
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/slnt-backslant-variable-expected.html: Added Test Case Expectations
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/at-font-face-matching-expected.txt: Updated Test Expectations
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/resources/FontStyleTest-slnt_backslant-VF.woff2 Added Test Font
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/resources/FontStyleTest-slnt-VF.woff2: Added Test Font
* LayoutTests/fast/text/font-style-parse.html: Rebaselined
* LayoutTests/fast/text/font-style-parse-expected.txt: Rebaselined
* LayoutTests/platform/glib/TestExpectations: Add "Failure" Expectation with reference bug
* LayoutTests/platform/ios/TestExpectations: Add "Failure" Expectation with reference bug
* LayoutTests/platform/mac/TestExpectations: Add "Failure" Expectation with reference bug

Canonical link: https://commits.webkit.org/258722@main




More information about the webkit-changes mailing list