[webkit-changes] [WebKit/WebKit] 1f8605: Disallow MSE with mp4 should AVStreamDataParser be...

Jean-Yves Avenard noreply at github.com
Tue Jan 10 05:09:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f860580a5b3d46064f0bae485fa060c68e5c655
      https://github.com/WebKit/WebKit/commit/1f860580a5b3d46064f0bae485fa060c68e5c655
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm

  Log Message:
  -----------
  Disallow MSE with mp4 should AVStreamDataParser be non-functional
https://bugs.webkit.org/show_bug.cgi?id=250367
rdar://104065947

Reviewed by Youenn Fablet.

On iPhone, MSE is disabled by default.
It can be enabled using an experimental setting, however it is mostly non-functional
as the SourceBufferParserAVFObjC relies on AVStreamDataParser class which itself is non-functional.
So testing for the availability of this class isn't sufficient,
we need to test that the init method itself doesn't return nil.

No test, as currently all MSE tests are disabled on iOS, and enabling those is out of scope for this change.i
On other platforms, covered by existing tests.

* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::isContentTypeSupported):

Canonical link: https://commits.webkit.org/258716@main




More information about the webkit-changes mailing list