[webkit-changes] [WebKit/WebKit] e72cc2: [css-transitions] css/css-properties-values-api/an...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e72cc27717779c52c64b8cfffb554584ff431852
      https://github.com/WebKit/WebKit/commit/e72cc27717779c52c64b8cfffb554584ff431852
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution-expected.txt
    M LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-inherited-used-by-standard-property-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  [css-transitions] css/css-properties-values-api/animation/custom-property-transition-inherited-used-by-standard-property.html is a failure
https://bugs.webkit.org/show_bug.cgi?id=249640
rdar://103549960

Reviewed by Antoine Quint.

* LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution-expected.txt:
* LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution.html:

Change the test to verify that sibling cases don't trigger recalc.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-inherited-used-by-standard-property-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::hasValidStyleForProperty):

Remove an optimization where we try to avoid style recalc while having a invalid ancestor style. This can't be done in general case
since there can be complex relationships between properties (via var() and em units for example).

The optimization is narrow and probably not valuable in practice.

(WebCore::isImplicitlyInheritedGridOrFlexProperty): Deleted.
(WebCore::nonInheritedColorPropertyHasValueCurrentColor): Deleted.

Canonical link: https://commits.webkit.org/258714@main