[webkit-changes] [WebKit/WebKit] bb2cc1: Nullptr crash in effectiveAssignedNodes

Ryosuke Niwa noreply at github.com
Tue Jan 10 01:44:20 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bb2cc188a3a9874b408ef972bd7e0eb8442007f0
      https://github.com/WebKit/WebKit/commit/bb2cc188a3a9874b408ef972bd7e0eb8442007f0
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    A LayoutTests/fast/shadow-dom/manual-slot-gc-crash-expected.txt
    A LayoutTests/fast/shadow-dom/manual-slot-gc-crash.html
    M Source/WebCore/dom/SlotAssignment.cpp

  Log Message:
  -----------
  Nullptr crash in effectiveAssignedNodes
https://bugs.webkit.org/show_bug.cgi?id=250365

Reviewed by Alexey Shvayka and Tim Nguyen.

Add a nullptr check in effectiveAssignedNodes.

* LayoutTests/fast/shadow-dom/manual-slot-gc-crash-expected.txt: Added.
* LayoutTests/fast/shadow-dom/manual-slot-gc-crash.html: Added.
* Source/WebCore/dom/SlotAssignment.cpp:
(WebCore::effectiveAssignedNodes):

Canonical link: https://commits.webkit.org/258708@main




More information about the webkit-changes mailing list