[webkit-changes] [WebKit/WebKit] 1940d5: font-face src local() doesn't invalidate css-wide ...

Vitor Roriz noreply at github.com
Mon Jan 9 18:57:12 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1940d518c6502f1340ce118692c79ba0b7afa9f1
      https://github.com/WebKit/WebKit/commit/1940d518c6502f1340ce118692c79ba0b7afa9f1
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-list-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-local-expected.txt
    M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp

  Log Message:
  -----------
  font-face src local() doesn't invalidate css-wide keywords
https://bugs.webkit.org/show_bug.cgi?id=250321
rdar://104028095

Reviewed by Tim Nguyen.

When we parse src for @font-face, CSS-wide keywords are not valid for local(). In case they are the only keywords being input for local, CSSPropertyParserHelpers::concatenateFamilyName will produce a null String, but we won't invalidate the CSSValue for that case.

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-list-expected.txt:
This fix exposes a failure on font-face-src-list, which is being tracked by https://bugs.webkit.org/show_bug.cgi?id=250332.

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-local-expected.txt:
* Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp:
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcLocal):

Canonical link: https://commits.webkit.org/258695@main




More information about the webkit-changes mailing list