[webkit-changes] [WebKit/WebKit] 1a660c: Do not automatically enable 'developer' features d...

[EWS]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a660cb880b4f36210f34d76055019f5e2057896
      https://github.com/WebKit/WebKit/commit/1a660cb880b4f36210f34d76055019f5e2057896
  Author: Brent Fulgham <bfulgham at webkit.org>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M Source/WTF/Scripts/GeneratePreferences.rb
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb

  Log Message:
  -----------
  Do not automatically enable 'developer' features during tests
https://bugs.webkit.org/show_bug.cgi?id=250235
<rdar://problem/103969233>

Reviewed by Elliott Williams.

The generator logic added in Bug 247926 also activated features with 'developer'
status while running tests.

This is wrong for a couple of reasons:
(1) The 'developer' flags with a defaultValue of 'false' are generally not relevant to our
automated testing (e.g., enabling security-violating CORS state, enabling features not meant
for web use cases, etc.
(2) TestWebKitAPI tests that need these special settings already enable the individually, so
we should not hard-set them to 'true' at each test iteration, as this can also enable features
on platforms or configurations that need these features to be off.

This patch limits the "automatically enabled" feature flags to those that are marked as
'preview', 'testable', or 'stable'.

* Source/WTF/Scripts/GeneratePreferences.rb:
* Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb:

Canonical link: https://commits.webkit.org/258681@main