[webkit-changes] [WebKit/WebKit] d69d0f: Support timestamps on WI console

mokjasmine noreply at github.com
Mon Jan 9 11:23:57 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d69d0f7bc8d83054032900f13091b03d9a724212
      https://github.com/WebKit/WebKit/commit/d69d0f7bc8d83054032900f13091b03d9a724212
  Author: mokjasmine <jasmine.mok at sony.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M LayoutTests/inspector/console/console-api-expected.txt
    M LayoutTests/inspector/console/console-api.html
    M LayoutTests/inspector/console/console-table-expected.txt
    M LayoutTests/inspector/console/console-table.html
    M LayoutTests/inspector/worker/console-basic-expected.txt
    M LayoutTests/inspector/worker/console-basic.html
    M Source/JavaScriptCore/inspector/ConsoleMessage.cpp
    M Source/JavaScriptCore/inspector/protocol/Console.json
    M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    M Source/WebInspectorUI/UserInterface/Base/Setting.js
    M Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
    M Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
    M Source/WebInspectorUI/UserInterface/Protocol/ConsoleObserver.js
    M Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css
    M Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js
    M Source/WebInspectorUI/UserInterface/Views/LogContentView.js
    M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

  Log Message:
  -----------
  Support timestamps on WI console
https://bugs.webkit.org/show_bug.cgi?id=248240

Reviewed by Patrick Angle.

We want a toggle-able flag in web inspector's console for showing a timestamp per console message.
Send the timestamp from the backend and display per console message. For duplicate messages, keep the repeat count and update the timestamp to that of the latest console message.
Collapse/expand functionality for duplicate messages when toggling off/on timestamps will come in a future PR.

-LayoutTests/inspector/console/console-api-expected.txt
-LayoutTests/inspector/console/console-api.html
-LayoutTests/inspector/worker/console-basic-expected.txt
-LayoutTests/inspector/worker/console-basic.html
-LayoutTests/inspector/console/console-table-expected.txt
-LayoutTests/inspector/console/console-table.html
-Source/JavaScriptCore/inspector/ConsoleMessage.cpp
-Source/JavaScriptCore/inspector/protocol/Console.json
-Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
-Source/WebInspectorUI/UserInterface/Base/Setting.js
-Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
-Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
-Source/WebInspectorUI/UserInterface/Protocol/ConsoleObserver.js
-Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.css
-Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js
-Source/WebInspectorUI/UserInterface/Views/LogContentView.js
-Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

Canonical link: https://commits.webkit.org/258675@main




More information about the webkit-changes mailing list