[webkit-changes] [WebKit/WebKit] 0b9475: [UI-side compositing] Some scrolling tests time ou...

Simon Fraser noreply at github.com
Mon Jan 9 10:11:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b9475d56e4239abc331fd2483e6572dd4ce124a
      https://github.com/WebKit/WebKit/commit/0b9475d56e4239abc331fd2483e6572dd4ce124a
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M LayoutTests/resources/ui-helper.js

  Log Message:
  -----------
  [UI-side compositing] Some scrolling tests time out with UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=250248
rdar://103974484

Reviewed by Tim Horton.

Tests using UIHelper.startMonitoringWheelEvents() still time out after 258483 at main and 258549 at main
because waiting for a rendering update in the web process before dispatching wheel events is not enough;
we need to wait for the UI process to commit the transaction that enables the wheel event monitor.

So in UIHelper.startMonitoringWheelEvents(), await a presentation update.

For WebKit1, UIHelper.ensurePresentationUpdate() needs to wait for a rendering update,
not just a display, otherwise NSView state may not have been updated yet (indicated by
failures in fast/scrolling/overflow-scroll-past-max.html).

* LayoutTests/resources/ui-helper.js:
(window.UIHelper.async startMonitoringWheelEvents):
(window.UIHelper.async ensurePresentationUpdate):
(window.UIHelper.async ensureStablePresentationUpdate):

Canonical link: https://commits.webkit.org/258670@main




More information about the webkit-changes mailing list