[webkit-changes] [WebKit/WebKit] 99c0f8: ArgumentCoderTests should provide facilities for e...

Žan Doberšek noreply at github.com
Mon Jan 9 08:58:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 99c0f8b4cfbdecaae4054afb4973c8addf33c659
      https://github.com/WebKit/WebKit/commit/99c0f8b4cfbdecaae4054afb4973c8addf33c659
  Author: Žan Doberšek <zdobersek at igalia.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp

  Log Message:
  -----------
  ArgumentCoderTests should provide facilities for encoder-generic typed testing suites
https://bugs.webkit.org/show_bug.cgi?id=249868

Reviewed by Kimmo Kinnunen.

In ArgumentCoderTests unit testing file, ArgumentCoderEncoderDecoderTest is
turned into a template of which two specializations are provided, one for
IPC::Encoder and the other for IPC::StreamConnectionEncoder. This enables test
fixtures that can be used in test cases that cover functionality of both
encoders.

The existing set of ArgumentCoderDecodingMoveCounterTest tests is converted into
one such suite, now covering both types of encoders.

* Tools/TestWebKitAPI/Tests/IPC/ArgumentCoderTests.cpp:
(TestWebKitAPI::EncoderDecoderTest::name):
(TestWebKitAPI::EncoderTypeNames::GetName):
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::Encoder>::encoder const):
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::Encoder>::headerSize const):
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::Encoder>::encoderSize const):
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::Encoder>::createDecoder const):
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::StreamConnectionEncoder>::encoder const):
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::StreamConnectionEncoder>::headerSize const):
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::StreamConnectionEncoder>::encoderSize const):
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::StreamConnectionEncoder>::createDecoder const):
(TestWebKitAPI::ArgumentCoderEncoderDecoderTest<IPC::StreamConnectionEncoder>::Impl::Impl):
(TestWebKitAPI::EncodingCounter::encode const):
(TestWebKitAPI::EncodingCounter::encode):
(TestWebKitAPI::DecodingMoveCounter::encode):
(TestWebKitAPI::DecodingMoveCounter::decode):
(TestWebKitAPI::TYPED_TEST_P):
(TestWebKitAPI::DecodingMoveCounterTest::name): Deleted.
(TestWebKitAPI::ArgumentCoderDecodingMoveCounterTest::encoder const): Deleted.
(TestWebKitAPI::ArgumentCoderDecodingMoveCounterTest::createDecoder const): Deleted.
(TestWebKitAPI::TEST_F): Deleted.

Canonical link: https://commits.webkit.org/258668@main




More information about the webkit-changes mailing list