[webkit-changes] [WebKit/WebKit] 4f70db: [GStreamer][MediaStream] Misc media capture improv...

Philippe Normand noreply at github.com
Mon Jan 9 05:04:20 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f70db078a9a41587d03e48b9c8b52b60e5d13d8
      https://github.com/WebKit/WebKit/commit/4f70db078a9a41587d03e48b9c8b52b60e5d13d8
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.h
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp

  Log Message:
  -----------
  [GStreamer][MediaStream] Misc media capture improvements
https://bugs.webkit.org/show_bug.cgi?id=249938

Reviewed by Xabier Rodriguez-Calvar.

Video frame metadata was attached only for mock sources. There's no need for a tee in the capturer
pipeline because there's never more than one client. Multiple observers watch for samples received
by the sink. And a few other drive-by and coding style cleanups.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:
(WebCore::GStreamerAudioCaptureSource::newSampleCallback):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.cpp:
(WebCore::initializeDebugCategory):
(WebCore::GStreamerAudioCapturer::GStreamerAudioCapturer):
(WebCore::GStreamerAudioCapturer::createConverter):
(WebCore::GStreamerAudioCapturer::setSampleRate):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:
(WebCore::GStreamerCapturer::createSource):
(WebCore::GStreamerCapturer::setupPipeline):
(WebCore::GStreamerCapturer::makeElement):
(WebCore::GStreamerCapturer::addSink): Deleted.
* Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.h:
* Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp:
* Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp:

Canonical link: https://commits.webkit.org/258662@main




More information about the webkit-changes mailing list