[webkit-changes] [WebKit/WebKit] 8e3609: [WebGPU] Support tier1 level argument buffers

mwyrzykowski noreply at github.com
Sun Jan 8 23:09:13 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8e360957f9200747edec0562115accd8920c744b
      https://github.com/WebKit/WebKit/commit/8e360957f9200747edec0562115accd8920c744b
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-01-08 (Sun, 08 Jan 2023)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/BindGroupLayout.h
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/RenderPipeline.mm

  Log Message:
  -----------
  [WebGPU] Support tier1 level argument buffers
https://bugs.webkit.org/show_bug.cgi?id=250123
<radar://103905011>

Reviewed by Myles C. Maxfield.

Support Tier1 argument buffers which are limited to
pre-A13 devices and some Intel Macs.

Tested on a pre-A13 iPad Pro.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::sizeOfEntries):
(WebGPU::Device::createBindGroup):
Support tier1 ABs.

* Source/WebGPU/WebGPU/BindGroupLayout.h:
(WebGPU::BindGroupLayout::create):
Simplify create function.

* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::createArgumentDescriptor):
(WebGPU::addDescriptor):
(WebGPU::Device::createBindGroupLayout):
(WebGPU::BindGroupLayout::BindGroupLayout):
(WebGPU::BindGroupLayout::encodedLength const):
Support tier1 ABs.

* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::createEntryFromStructMember):
(WebGPU::RenderPipeline::getBindGroupLayout):
Call Device::createBindLayout instead and pass some additional
information to be compatible with Tier1 ABs.

Canonical link: https://commits.webkit.org/258651@main




More information about the webkit-changes mailing list