[webkit-changes] [WebKit/WebKit] 113459: Clean up DeprecatedGlobalSettings

Tim Nguyen noreply at github.com
Sun Jan 8 14:39:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 113459009e442af44e8913a60533c3fb3ee8a5c7
      https://github.com/WebKit/WebKit/commit/113459009e442af44e8913a60533c3fb3ee8a5c7
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-01-08 (Sun, 08 Jan 2023)

  Changed paths:
    M Source/WebCore/page/DeprecatedGlobalSettings.cpp
    M Source/WebCore/page/DeprecatedGlobalSettings.h

  Log Message:
  -----------
  Clean up DeprecatedGlobalSettings
https://bugs.webkit.org/show_bug.cgi?id=250284
rdar://103994908

Reviewed by Darin Adler.

- Remove unused fields
- Move m_networkInterfaceName to `#if PLATFORM(IOS_FAMILY)` since it's only used there
- Remove unused WEBCORE_EXPORT
- Remove constructor and just initialize fields accordingly
- Inline some method definitions

* Source/WebCore/page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::DeprecatedGlobalSettings): Deleted.
(WebCore::DeprecatedGlobalSettings::setNetworkInterfaceName):
(WebCore::DeprecatedGlobalSettings::mockScrollbarsEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::usesOverlayScrollbars): Deleted.
(WebCore::DeprecatedGlobalSettings::setLowPowerVideoAudioBufferSizeEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::networkDataUsageTrackingEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::networkInterfaceName): Deleted.
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::mockScrollbarsEnabled):
(WebCore::DeprecatedGlobalSettings::usesOverlayScrollbars):
(WebCore::DeprecatedGlobalSettings::setLowPowerVideoAudioBufferSizeEnabled):
(WebCore::DeprecatedGlobalSettings::networkDataUsageTrackingEnabled):
(WebCore::DeprecatedGlobalSettings::networkInterfaceName):

Canonical link: https://commits.webkit.org/258643@main




More information about the webkit-changes mailing list