[webkit-changes] [WebKit/WebKit] 866813: [web-animations] consider using Ref<> instead of R...

Antoine Quint noreply at github.com
Sun Jan 8 02:53:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 866813ec2e4eb4f8646237cccfe1ad3ad76f46e1
      https://github.com/WebKit/WebKit/commit/866813ec2e4eb4f8646237cccfe1ad3ad76f46e1
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-01-08 (Sun, 08 Jan 2023)

  Changed paths:
    M Source/WebCore/animation/AnimationTimeline.cpp
    M Source/WebCore/animation/DocumentTimeline.cpp
    M Source/WebCore/animation/DocumentTimeline.h
    M Source/WebCore/animation/DocumentTimelinesController.cpp
    M Source/WebCore/animation/WebAnimationTypes.h
    M Source/WebCore/page/PageColorSampler.cpp
    M Source/WebCore/style/Styleable.cpp

  Log Message:
  -----------
  [web-animations] consider using Ref<> instead of RefPtr<> in the various types defined in WebAnimationTypes.h
https://bugs.webkit.org/show_bug.cgi?id=249530
rdar://103683475

Reviewed by Darin Adler and Alexey Shvayka.

We switch the AnimationCollection, CSSAnimationCollection and AnimatablePropertyToTransitionMap types
to use Ref<> instead of RefPtr<>.

* Source/WebCore/animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::animationTimingDidChange):
(WebCore::AnimationTimeline::removeAnimation):
* Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::transitionDidComplete):
* Source/WebCore/animation/DocumentTimeline.h:
* Source/WebCore/animation/DocumentTimelinesController.cpp:
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):
* Source/WebCore/animation/WebAnimationTypes.h:
* Source/WebCore/page/PageColorSampler.cpp:
(WebCore::isValidSampleLocation):
* Source/WebCore/style/Styleable.cpp:
(WebCore::Styleable::animationWasAdded const):
(WebCore::removeCSSTransitionFromMap):
(WebCore::Styleable::animationWasRemoved const):
(WebCore::Styleable::cancelDeclarativeAnimations const):

Canonical link: https://commits.webkit.org/258631@main




More information about the webkit-changes mailing list