[webkit-changes] [WebKit/WebKit] 055784: Invoke ValidatedFormListedElement::parseReadOnlyAt...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05578471c16ebe4939cd5606f9491c0c600187eb
      https://github.com/WebKit/WebKit/commit/05578471c16ebe4939cd5606f9491c0c600187eb
  Author: Alexey Shvayka <ashvayka at apple.com>
  Date:   2023-01-07 (Sat, 07 Jan 2023)

  Changed paths:
    M Source/WebCore/html/FormAssociatedCustomElement.cpp
    M Source/WebCore/html/ValidatedFormListedElement.cpp
    M Source/WebCore/html/ValidatedFormListedElement.h

  Log Message:
  -----------
  Invoke ValidatedFormListedElement::parseReadOnlyAttribute() conditionally
https://bugs.webkit.org/show_bug.cgi?id=250268

Reviewed by Ryosuke Niwa.

Since not all inherently validated form controls care about "readonly" attribute
(namely <button>, <select>, and <fieldset>), this change guards parseReadOnlyAttribute()
with a readOnlyBarsFromConstraintValidation() check.

Also adds an assert that controls which supportsReadOnly() are subset of those who are
barred from constraint validation if "readonly" is present, and renames "parseReadonlyAttribute"
to match case with other methods.

No new tests, no behavior change.

* Source/WebCore/html/FormAssociatedCustomElement.cpp:
(WebCore::FormAssociatedCustomElement::didUpgrade):
* Source/WebCore/html/ValidatedFormListedElement.cpp:
(WebCore::ValidatedFormListedElement::parseAttribute):
(WebCore::ValidatedFormListedElement::parseReadOnlyAttribute):
(WebCore::ValidatedFormListedElement::parseReadonlyAttribute): Deleted.
* Source/WebCore/html/ValidatedFormListedElement.h:

Canonical link: https://commits.webkit.org/258621@main