[webkit-changes] [WebKit/WebKit] 134163: Getting input.value for number inputs (type=number...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 134163e4e3101c02038c4447672158e4a2fac445
      https://github.com/WebKit/WebKit/commit/134163e4e3101c02038c4447672158e4a2fac445
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-07 (Sat, 07 Jan 2023)

  Changed paths:
    M LayoutTests/fast/forms/number/number-stepup-stepdown-expected.txt
    M LayoutTests/fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt
    M LayoutTests/fast/forms/number/number-stepup-stepdown-from-renderer.html
    M LayoutTests/fast/forms/number/number-stepup-stepdown.html
    M LayoutTests/fast/forms/number/number-valueasnumber-expected.txt
    M LayoutTests/fast/forms/number/number-valueasnumber.html
    M Source/WebCore/html/NumberInputType.cpp
    M Source/WebCore/html/parser/HTMLParserIdioms.cpp

  Log Message:
  -----------
  Getting input.value for number inputs (type=number) with over 39 characters returns an empty string

Getting input.value for number inputs (type=number) with over 39 characters returns an empty string
https://bugs.webkit.org/show_bug.cgi?id=249783

Reviewed by Ryosuke Niwa.

This patch is to align WebKit with Blink / Chromium, Firefox / Gecko and Web-Specification.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=168513

Number input type maximum value increased from float to double.
Float allowed only max value of 3.402823466e38, it has now been
increased to 1.7976931348623158e+308, by using double.

InvalidStateError exception is removed from
NumberInputType::setValueAsDouble and
NumberInputType::setValueAsDecimal, as HTMLInputType::setValueAsNumber checks if value is infinite.

HTMLParserIdioms has also been updated as the functions are
triggered in NumberInputType functions and has check for max
values, thus updated.

* Source/WebCore/html/NumberInputType.cpp:
(NumberInputType::valueAsDouble):
- Updated Comment and also removed FIXME
(NumberInputType::valueAsDecimal):
- Updated Comment and also removed FIXME
(NumberInputType::createStepRange):
(1) Remove "FIXME"
(2) Use "doubleMax" instead of "floatMax"
* Source/WebCore/html/parser/HTMLParserIdioms.cpp:
(parseToDecimalForNumberType):
(1) Updated Comment and also removed FIXME
(2) Use "doubleMax" instead of "floatMax"
(3) Update condition to ASSERT
* LayoutTests/fast/forms/number/number-valueasnumber.html: Updated
* LayoutTests/fast/forms/number/number-valueasnumber-expected.txt: Ditto
* LayoutTests/fast/forms/number/number-stepup-stepdown.html: Updated
* LayoutTests/fast/forms/number/number-stepup-stepdown-expected.txt: Ditto
* LayoutTests/fast/forms/number/number-stepup-stepdown-from-renderer.html: Updated
* LayoutTests/fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt: Ditto

Canonical link: https://commits.webkit.org/258614@main