[webkit-changes] [WebKit/WebKit] c3b5f3: Remove WebSocketEnabled & IsNSURLSessionWebSocketE...

Tim Nguyen noreply at github.com
Fri Jan 6 21:32:19 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c3b5f312a71d8598ff1727d406a0782074fbd35f
      https://github.com/WebKit/WebKit/commit/c3b5f312a71d8598ff1727d406a0782074fbd35f
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp
    M Source/WebCore/Modules/websockets/WebSocket.cpp
    M Source/WebCore/Modules/websockets/WebSocket.idl
    M Source/WebCore/page/DeprecatedGlobalSettings.cpp
    M Source/WebCore/page/DeprecatedGlobalSettings.h

  Log Message:
  -----------
  Remove WebSocketEnabled & IsNSURLSessionWebSocketEnabled from DeprecatedGlobalSettings
https://bugs.webkit.org/show_bug.cgi?id=250244
rdar://103973264

Reviewed by Brent Fulgham and Tim Horton.

Use settingsValues and [EnabledBySetting].

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::create):
* Source/WebCore/Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
* Source/WebCore/Modules/websockets/WebSocket.idl:
* Source/WebCore/page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::DeprecatedGlobalSettings):
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::setWebSocketEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::webSocketEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::isNSURLSessionWebSocketEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::setIsNSURLSessionWebSocketEnabled): Deleted.

scriptExecutionContext() should always exist given it is passed with the constructor as a reference.

Canonical link: https://commits.webkit.org/258602@main




More information about the webkit-changes mailing list