[webkit-changes] [WebKit/WebKit] e87838: Include overflows from visual effects in RenderTable

Ahmad Saleem noreply at github.com
Fri Jan 6 19:29:37 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e87838633996aea9c5bf950e843d297baf78d224
      https://github.com/WebKit/WebKit/commit/e87838633996aea9c5bf950e843d297baf78d224
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    A LayoutTests/fast/repaint/table-section-visual-overflow-expected.txt
    A LayoutTests/fast/repaint/table-section-visual-overflow.html
    M Source/WebCore/rendering/RenderTable.cpp

  Log Message:
  -----------
  Include overflows from visual effects in RenderTable

Include overflows from visual effects in RenderTable
https://bugs.webkit.org/show_bug.cgi?id=249279

Reviewed by Alan Baradlay.

This patch is to fix repaint issue in WebKit, which is not present in Blink / Chromium and Gecko / Firefox.

Merge - https://src.chromium.org/viewvc/blink?view=rev&revision=196609

By not including visual overflow effects results in incorrect paint invalidation (as exhibited by the attached test), and also incorrect painting.

* Source/WebCore/rendering/RenderTable.cpp:
(RenderTable::simplifiedNormalFlowLayout): Account for 'addVisualEffectOverflow'
(RenderTable::layout): Ditto
* LayoutTests/fast/repaint/table-section-visual-overflow.html: Add Test Case
* LayoutTests/fast/repaint/table-section-visual-overflow-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/258596@main




More information about the webkit-changes mailing list