[webkit-changes] [WebKit/WebKit] e29dfa: REGRESSION(255641 at main): Web process crash in WebC...

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e29dfab61f35b45f262f1c25945f518f3c994aa5
      https://github.com/WebKit/WebKit/commit/e29dfab61f35b45f262f1c25945f518f3c994aa5
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderLayerCompositor.cpp

  Log Message:
  -----------
  REGRESSION(255641 at main): Web process crash in WebCore::isDescendantOfFullScreenLayer when when fullscreening video on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=249689

Reviewed by Brent Fulgham and Tim Nguyen.

Currently we crash if the downcast here fails. The code inconsistently
expects it to always succeed, then checks for failure right below. Check
first. This seems to be all that's required to fix fullscreen video on
reddit.com.

* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::isDescendantOfFullScreenLayer):

Canonical link: https://commits.webkit.org/258593@main