[webkit-changes] [WebKit/WebKit] 38a2ac: Remove HTMLFrameElement.width/height

Ahmad Saleem noreply at github.com
Fri Jan 6 16:08:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38a2ac2c30f9b89f8b2040285fa78b96b83389a1
      https://github.com/WebKit/WebKit/commit/38a2ac2c30f9b89f8b2040285fa78b96b83389a1
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M LayoutTests/fast/frames/frame-deep-nested-resize.html
    M LayoutTests/fast/frames/frame-inherit-noresize-from-frameset-expected.txt
    M LayoutTests/fast/frames/frame-js-url-clientWidth-expected.txt
    M LayoutTests/fast/frames/frame-js-url-clientWidth.html
    M LayoutTests/fast/frames/frame-programmatic-noresize-expected.txt
    M LayoutTests/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt
    M LayoutTests/fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false-expected.txt
    R LayoutTests/fast/frames/frameElement-widthheight-expected.txt
    R LayoutTests/fast/frames/frameElement-widthheight.html
    M LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html
    M LayoutTests/fast/frames/resources/frame-programmatic-resize.js
    M Source/WebCore/html/HTMLFrameElement.idl
    M Source/WebCore/html/HTMLFrameElementBase.cpp
    M Source/WebCore/html/HTMLFrameElementBase.h
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFrameElement.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFrameElement.h
    M Source/WebKitLegacy/mac/DOM/DOMHTMLFrameElement.mm

  Log Message:
  -----------
  Remove HTMLFrameElement.width/height

Remove HTMLFrameElement.width/height
https://bugs.webkit.org/show_bug.cgi?id=249966

Reviewed by Michael Catanzaro and Ryosuke Niwa.

This patch is to align WebKit with Gecko / Firefox and Blink / Chromium by removing non-standard attributes.

Merge - https://src.chromium.org/viewvc/blink?view=rev&revision=179130

This patch removes 'height' and 'width' attributes from the frame element, wihch were non-standard and was supported only in Internet Explorer 11 and WebKit. These were never supported by Gecko and later removed by Blink in 2014.

* Source/WebCore/html/HTMLFrameElement.idl: Remove 'height' and 'width'
* Source/WebCore/html/HTMLFrameElementBase.h: Remove 'height' and 'width' definitions
* Source/WebCore/html/HTMLFrameElementBase.cpp: Remove 'height' and 'width' functions
* Source/WebKitLegacy/mac/DOM/DOMHTMLFrameElement.mm: Ditto
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFrameElement.cpp: Update to return "0" for 'height' and 'width'
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLFrameElement.h: Update "return" comment
* LayoutTests/fast/frames/resources/frame-programmatic-resize.js: Rebaselined
* LayoutTests/fast/frames/frames-with-frameborder-zero-can-be-resized.html: Rebaselined
* LayoutTests/fast/frames/frame-deep-nested-resize.html: Rebaselined
* LayoutTests/fast/frames/frame-inherit-noresize-from-frameset-expected.txt: Rebaselined
* LayoutTests/fast/frames/frame-js-url-clientWidth.html: Rebaselined
* LayoutTests/fast/frames/frame-js-url-clientWidth-expected.txt: Rebaselined
* LayoutTests/fast/frames/frame-programmatic-noresize-expected.txt: Rebaselined
* LayoutTests/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-expected.txt: Rebaselined
* LayoutTests/fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize-to-false-expected.txt: Rebaselined
* LayoutTests/fast/frames/frameElement-widthheight.html: Deleted
* LayoutTests/fast/frames/frameElement-widthheight-expected.txt: Ditto

Canonical link: https://commits.webkit.org/258573@main




More information about the webkit-changes mailing list