[webkit-changes] [WebKit/WebKit] 2d409b: REGRESSION(257981 at main): Form control focus ring i...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d409b2f1e103e048861aed8fc62931fe4a94ae8
      https://github.com/WebKit/WebKit/commit/2d409b2f1e103e048861aed8fc62931fe4a94ae8
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm

  Log Message:
  -----------
  REGRESSION(257981 at main): Form control focus ring is clipped when zooming in
https://bugs.webkit.org/show_bug.cgi?id=250215
rdar://103958015

Reviewed by Aditya Keerthi.

In ControlMac::drawCell(), the drawing will be routed to an ImageBuffer if the
page is zoomed. When the form control is focused, AppKit is asked to draw  a
focus ring around the rectangle of the form control. AppKit bleeds at maximum
three pixels around the drawing rectangle.

Like what ThemeMac::drawCellOrFocusRingWithViewIntoContext() does in this case,
we need to inflate the size of the ImageBuffer by three pixels.

* Source/WebCore/platform/graphics/mac/controls/ControlMac.mm:
(WebCore::ControlMac::drawCell):

Canonical link: https://commits.webkit.org/258553@main