[webkit-changes] [WebKit/WebKit] 9f94ff: [GPU Process] [FormControls] Add ControlPart for C...

Said Abou-Hallawa noreply at github.com
Fri Jan 6 11:20:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f94ffa7eeaf4fcd2bb5c97643f78663db9a69e1
      https://github.com/WebKit/WebKit/commit/9f94ffa7eeaf4fcd2bb5c97643f78663db9a69e1
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/platform/graphics/controls/ColorWellPart.h
    M Source/WebCore/platform/graphics/controls/ControlFactory.h
    A Source/WebCore/platform/graphics/mac/controls/ColorWellMac.h
    A Source/WebCore/platform/graphics/mac/controls/ColorWellMac.mm
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
    M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
    M Source/WebCore/platform/graphics/mac/controls/MenuListMac.mm
    M Source/WebCore/platform/mac/ThemeMac.h
    M Source/WebCore/platform/mac/ThemeMac.mm
    M Source/WebCore/rendering/RenderTheme.cpp
    M Source/WebCore/rendering/RenderThemeMac.mm
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp

  Log Message:
  -----------
  [GPU Process] [FormControls] Add ControlPart for ColorWell
https://bugs.webkit.org/show_bug.cgi?id=249928
rdar://103748580

Reviewed by Aditya Keerthi.

The ColorWellPart will handle drawing the form control `<input type="color">` On
macOS, AppKit will be used to draw the platform control through ColorWellMac.

* Source/WebCore/Headers.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/controls/ColorWellPart.h: Added.
* Source/WebCore/platform/graphics/controls/ControlFactory.h:
* Source/WebCore/platform/graphics/mac/controls/ColorWellMac.h: Added.
* Source/WebCore/platform/graphics/mac/controls/ColorWellMac.mm: Added.
(WebCore::ColorWellMac::ColorWellMac):
(WebCore::ColorWellMac::updateCellStates):
(WebCore::ColorWellMac::draw):
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
(WebCore::ControlFactoryMac::createPlatformColorWell):
* Source/WebCore/platform/graphics/mac/controls/MenuListMac.mm:
* Source/WebCore/platform/mac/ThemeMac.h:
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::paintColorWell): Deleted.
(WebCore::ThemeMac::paint): Deleted.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::createControlPart const):
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::canPaint const):
(WebCore::RenderThemeMac::canCreateControlPartForRenderer const):
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ControlPart>::decode):

Canonical link: https://commits.webkit.org/258550@main




More information about the webkit-changes mailing list