[webkit-changes] [WebKit/WebKit] 549174: InlineIterator::LineBox::width/height/top/bottom a...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 54917406b3f6d9c469d91752ff32e8940c1fa748
      https://github.com/WebKit/WebKit/commit/54917406b3f6d9c469d91752ff32e8940c1fa748
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    M Source/WebCore/editing/VisibleUnits.cpp
    M Source/WebCore/layout/integration/inline/InlineIteratorLineBox.h
    M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h
    M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderLineBreak.cpp
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/RenderTextControlSingleLine.cpp

  Log Message:
  -----------
  InlineIterator::LineBox::width/height/top/bottom are logical values
https://bugs.webkit.org/show_bug.cgi?id=250174

Reviewed by Antti Koivisto.

They should read LineBox::logical*

* Source/WebCore/editing/VisibleUnits.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
* Source/WebCore/layout/integration/inline/InlineIteratorLineBox.h:
(WebCore::InlineIterator::LineBox::logicalHeight const):
(WebCore::InlineIterator::LineBox::logicalTop const):
(WebCore::InlineIterator::LineBox::logicalBottom const):
(WebCore::InlineIterator::LineBox::logicalWidth const):
(WebCore::InlineIterator::LineBox::height const): Deleted.
(WebCore::InlineIterator::LineBox::top const): Deleted.
(WebCore::InlineIterator::LineBox::bottom const): Deleted.
(WebCore::InlineIterator::LineBox::width const): Deleted.
* Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h:
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::logicalTop const):
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::logicalBottom const):
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::logicalWidth const):
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::top const): Deleted.
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::bottom const): Deleted.
(WebCore::InlineIterator::LineBoxIteratorLegacyPath::width const): Deleted.
* Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h:
(WebCore::InlineIterator::LineBoxIteratorModernPath::logicalTop const):
(WebCore::InlineIterator::LineBoxIteratorModernPath::logicalBottom const):
(WebCore::InlineIterator::LineBoxIteratorModernPath::logicalWidth const):
(WebCore::InlineIterator::LineBoxIteratorModernPath::top const): Deleted.
(WebCore::InlineIterator::LineBoxIteratorModernPath::bottom const): Deleted.
(WebCore::InlineIterator::LineBoxIteratorModernPath::width const): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
* Source/WebCore/rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):

Canonical link: https://commits.webkit.org/258546@main