[webkit-changes] [WebKit/WebKit] 7da5d9: Masonry Alignment and Spacing align-tracks and jus...

Brandon Stewart noreply at github.com
Fri Jan 6 08:50:46 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7da5d95cea57de320f5eebdf30e3cadacb3d7186
      https://github.com/WebKit/WebKit/commit/7da5d95cea57de320f5eebdf30e3cadacb3d7186
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2023-01-06 (Fri, 06 Jan 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-computed-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-computed.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-invalid-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-invalid.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-valid-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/align-tracks-valid.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-computed-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-computed.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-invalid-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-invalid.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-valid-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/parsing/justify-tracks-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/StyleGridData.cpp
    M Source/WebCore/rendering/style/StyleGridData.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  Masonry Alignment and Spacing align-tracks and justify-tracks
https://bugs.webkit.org/show_bug.cgi?id=248835
rdar://102782713

Reviewed by Tim Nguyen.

Add initial support for align-tracks and justify-tracks in Masonry layout.
These new properties resemble align-content and justify-content, with the addition of being able
to have multiple items so you can specify for each track.

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator AlignTracks const):
(WebCore::CSSPrimitiveValue::operator JustifyTracks const):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAlignTracks):
(WebCore::CSSPropertyParserHelpers::consumeJustifyTracks):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::alignTracks const):
(WebCore::RenderStyle::justifyTracks const):
(WebCore::RenderStyle::setAlignTracks):
(WebCore::RenderStyle::setJustifyTracks):
(WebCore::RenderStyle::initialAlignTracks):
(WebCore::RenderStyle::initialJustifyTracks):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* Source/WebCore/rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator== const):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertAlignTracks):
(WebCore::Style::BuilderConverter::convertJustifyTracks):

Canonical link: https://commits.webkit.org/258544@main




More information about the webkit-changes mailing list