[webkit-changes] [WebKit/WebKit] ad60a4: [Live Range Selection] AcceptsFirstMouse fails
Ryosuke Niwa
noreply at github.com
Thu Jan 5 16:20:48 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ad60a462ad8d80096b054f8d9d2148fab18a3ebc
https://github.com/WebKit/WebKit/commit/ad60a462ad8d80096b054f8d9d2148fab18a3ebc
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2023-01-05 (Thu, 05 Jan 2023)
Changed paths:
M Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm
M Tools/TestWebKitAPI/Tests/mac/acceptsFirstMouse.html
Log Message:
-----------
[Live Range Selection] AcceptsFirstMouse fails
https://bugs.webkit.org/show_bug.cgi?id=250145
Reviewed by Wenson Hsieh.
The failure was caused by AcceptsFirstMouse.html using legacy editing offsets to select image.
Use valid offsets instead so that enabling live range selection doesn't break these test case.
Also workaround a bug that clicking on the next image doesn't clear selection by clicking
on the empty space right of the next image.
* Tools/TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
(TestWebKitAPI::AcceptsFirstMouse::runTest):
* Tools/TestWebKitAPI/Tests/mac/acceptsFirstMouse.html:
Canonical link: https://commits.webkit.org/258515@main
More information about the webkit-changes
mailing list