[webkit-changes] [WebKit/WebKit] 19d6f9: Remove unused AlignContent enum class

Tim Nguyen noreply at github.com
Thu Jan 5 13:54:23 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19d6f99587d7777b066ff2f1886be97ed694b182
      https://github.com/WebKit/WebKit/commit/19d6f99587d7777b066ff2f1886be97ed694b182
  Author: Tim Nguyen <ntim.bugs at gmail.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/rendering/style/RenderStyleConstants.h

  Log Message:
  -----------
  Remove unused AlignContent enum class
https://bugs.webkit.org/show_bug.cgi?id=250139

Reviewed by Brent Fulgham and Rob Buis.

align-content is now represented by StyleContentAlignmentData which can handle more complex combinations like:
- first baseline
- last baseline
- unsafe/safe center

AlignContent is a leftover from the implementation of those new combinations, that is confusing to keep in the codebase.

* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator AlignContent const): Deleted.
* Source/WebCore/rendering/style/RenderStyleConstants.h:

Canonical link: https://commits.webkit.org/258509@main




More information about the webkit-changes mailing list