[webkit-changes] [WebKit/WebKit] ba5d6a: [Cocoa, MSE] MSE video doesn't render in WK1 WebView

Eric Carlson noreply at github.com
Thu Jan 5 12:04:14 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ba5d6a18a598b8c8d8e328174609384590c0a3b2
      https://github.com/WebKit/WebKit/commit/ba5d6a18a598b8c8d8e328174609384590c0a3b2
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    A LayoutTests/media/media-source/content/test-red-3s-480x360.png
    A LayoutTests/media/media-source/media-source-video-renders-expected.html
    A LayoutTests/media/media-source/media-source-video-renders.html
    M LayoutTests/media/utilities.js
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

  Log Message:
  -----------
  [Cocoa, MSE] MSE video doesn't render in WK1 WebView
https://bugs.webkit.org/show_bug.cgi?id=250105
rdar://103696863

Reviewed by Wenson Hsieh.

252183 at main (rdar://96256430) updated the `MediaPlayerPrivateMediaSourceAVFObjC` logic for
rendering with an AVSampleBufferDisplayLayer or with a decompression session. The logic
includes a check of the `mediaSourceInlinePaintingEnabled` runtime flag, which is off by
default in WebKit 1, so it inadvertently disabled video in legacy WebViews.

* LayoutTests/media/media-source/content/test-red-3s-480x360.png: Added.
* LayoutTests/media/media-source/media-source-video-renders-expected.html: Added.
* LayoutTests/media/media-source/media-source-video-renders.html: Added.
* LayoutTests/media/utilities.js:
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Make the MediaSourceInlinePaintingEnabled
WebKitLegacy default the same as WebKit.

Canonical link: https://commits.webkit.org/258499@main




More information about the webkit-changes mailing list