[webkit-changes] [WebKit/WebKit] f9c590: [Live Range Selection] Some tests in TestWebKitAPI...
Ryosuke Niwa
noreply at github.com
Thu Jan 5 11:22:39 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f9c590ab3b9bbb8956fe14cd661126747bdd5a62
https://github.com/WebKit/WebKit/commit/f9c590ab3b9bbb8956fe14cd661126747bdd5a62
Author: Ryosuke Niwa <rniwa at webkit.org>
Date: 2023-01-05 (Thu, 05 Jan 2023)
Changed paths:
M Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm
Log Message:
-----------
[Live Range Selection] Some tests in TestWebKitAPI.FontManagerTests fail
https://bugs.webkit.org/show_bug.cgi?id=250122
Reviewed by Darin Adler.
The following test cases fail when enabling live range selection because they rely on canonicalized selection
to get the computed style via stylePropertyAtSelectionStart and stylePropertyAtSelectionEnd of TestWKWebView:
TestWebKitAPI.FontManagerTests.ChangeFontWithPanel
TestWebKitAPI.FontManagerTests.ChangeAttributesWithFontEffectsBox
TestWebKitAPI.FontManagerTests.ChangeFontColorWithColorPanel
Updated the test cases to assert HTML markup after modifying fonts instead of getting computed style
at the parent element of start or end container of selection, which is rather fragile.
* Tools/TestWebKitAPI/Tests/mac/FontManagerTests.mm:
(webViewForFontManagerTesting):
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/258496@main
More information about the webkit-changes
mailing list