[webkit-changes] [WebKit/WebKit] c672a5: [IFC][line-clamp] Incorrect ellipsis placement whe...

Alan Baradlay noreply at github.com
Thu Jan 5 10:41:48 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c672a5df57fceb94daff8177aaa9c9a512526c14
      https://github.com/WebKit/WebKit/commit/c672a5df57fceb94daff8177aaa9c9a512526c14
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-01-05 (Thu, 05 Jan 2023)

  Changed paths:
    A LayoutTests/fast/inline/line-clamp-with-text-align-expected.html
    A LayoutTests/fast/inline/line-clamp-with-text-align.html
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp

  Log Message:
  -----------
  [IFC][line-clamp] Incorrect ellipsis placement when text-align is not "start"
https://bugs.webkit.org/show_bug.cgi?id=249974

Reviewed by Antti Koivisto.

Do not assume that the truncated content is the result of overflowing where
the root inline box always starts at 0.
Move the ellipsis position by the alignment offset (this is specific to line clamping).

* LayoutTests/fast/inline/line-clamp-with-text-align-expected.html: Added.
* LayoutTests/fast/inline/line-clamp-with-text-align.html: Added.
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::InlineDisplayLineBuilder::trailingEllipsisRect const):

Canonical link: https://commits.webkit.org/258491@main




More information about the webkit-changes mailing list