[webkit-changes] [WebKit/WebKit] b011a6: [Live Range Selection] text recognition tests fail

Ryosuke Niwa noreply at github.com
Wed Jan 4 21:52:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b011a6f10fc0dfcb20bff7cf7bc2b1e53f21d5a7
      https://github.com/WebKit/WebKit/commit/b011a6f10fc0dfcb20bff7cf7bc2b1e53f21d5a7
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M LayoutTests/fast/images/text-recognition/mac/context-menu-for-image-in-link-contains-copy.html
    M LayoutTests/fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-2-expected.html
    M LayoutTests/fast/images/text-recognition/mac/select-word-in-draggable-image-overlay.html
    M LayoutTests/fast/images/text-recognition/mac/select-word-in-transparent-image-overlay.html

  Log Message:
  -----------
  [Live Range Selection] text recognition tests fail
https://bugs.webkit.org/show_bug.cgi?id=250114

Reviewed by Wenson Hsieh.

These tests rely on setBaseAndExtent being able to select contents inside a UA shadow tree,
which is no longer true once live range selection is enabled.

Use internals.setSelectionWithoutValidation instead.

* LayoutTests/fast/images/text-recognition/mac/context-menu-for-image-in-link-contains-copy.html:
* LayoutTests/fast/images/text-recognition/mac/select-image-overlay-with-mouse-drag-2-expected.html:
* LayoutTests/fast/images/text-recognition/mac/select-word-in-draggable-image-overlay.html:
* LayoutTests/fast/images/text-recognition/mac/select-word-in-transparent-image-overlay.html:

Canonical link: https://commits.webkit.org/258476@main




More information about the webkit-changes mailing list