[webkit-changes] [WebKit/WebKit] fe1655: _WKAuthenticatorAttestationResponse and _WKAuthent...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fe1655421cc54053541f73893479da9f25418daa
      https://github.com/WebKit/WebKit/commit/fe1655421cc54053541f73893479da9f25418daa
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponse.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponse.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.mm

  Log Message:
  -----------
  _WKAuthenticatorAttestationResponse and _WKAuthenticatorResponse should retain/copy their instance variables
https://bugs.webkit.org/show_bug.cgi?id=250080
<rdar://103876775>

Reviewed by Brent Fulgham.

Update @property declarations to retain instance variables
rather than storing them as unsafe-unretained, update init
methods to properly retain/copy the instance variables, and
add -dealloc methods to release instance variables.

* Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponse.h:
- Update @property declarations to store strong references.
* Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorAttestationResponse.mm:
(-[_WKAuthenticatorAttestationResponse initWithClientDataJSON:rawId:extensions:attestationObject:attachment:transports:]):
(-[_WKAuthenticatorAttestationResponse initWithClientDataJSON:rawId:extensionOutputsCBOR:attestationObject:attachment:transports:]):
- Retain or copy instance variables to match @property
  declarations.
(-[_WKAuthenticatorAttestationResponse dealloc]): Add.
- Release retained/copied instance variables to prevent leaks.

* Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.h:
- Update @property declarations to store strong references.
* Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorResponse.mm:
(-[_WKAuthenticatorResponse initWithClientDataJSON:rawId:extensions:attachment:]):
(-[_WKAuthenticatorResponse initWithClientDataJSON:rawId:extensionOutputsCBOR:attachment:]):
- Retain or copy instance variables to match @property
  declarations.
- Use WTFMove() to avoid ref churn of rvalue parameter.
(-[_WKAuthenticatorResponse dealloc]): Add.
- Release retained/copied instance variables to prevent leaks.

Canonical link: https://commits.webkit.org/258471@main