[webkit-changes] [WebKit/WebKit] f1fd9e: Potential Assertion Fix - Fix loop condition in Bi...

Ahmad Saleem noreply at github.com
Wed Jan 4 17:45:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f1fd9e9795a69fedff6f67401a3f77d93b81959e
      https://github.com/WebKit/WebKit/commit/f1fd9e9795a69fedff6f67401a3f77d93b81959e
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    A LayoutTests/fast/text/bidi-replace-runs-crash-expected.txt
    A LayoutTests/fast/text/bidi-replace-runs-crash.html
    M Source/WebCore/platform/text/BidiRunList.h

  Log Message:
  -----------
  Potential Assertion Fix - Fix loop condition in BidiRunList::replaceRunWithRuns

Potential Assertion Fix - Fix loop condition in BidiRunList::replaceRunWithRuns
https://bugs.webkit.org/show_bug.cgi?id=249968

Reviewed by Alan Baradlay.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=179068

This patch is to potentially fix an assertion on debug builds by fixing a loop condition in
BidiRunList::replaceRunWithRuns to check if next run exists before accessing it.

* Source/WebCore/platform/text/BidiRunList.h:
(BidiRunList<Run>::replaceRunwithRuns): update 'while' loop
* LayoutTests/fast/text/bidi-replace-runs-crash.html: Add Test Case
* LayoutTests/fast/text/bidi-replace-runs-crash-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/258465@main




More information about the webkit-changes mailing list