[webkit-changes] [WebKit/WebKit] d9e61b: [GPU Process] [FormControls] Add ControlParts for ...
Said Abou-Hallawa
noreply at github.com
Wed Jan 4 17:17:33 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d9e61bbb56beb116a6f42f89a97f6ed0adbbb8c0
https://github.com/WebKit/WebKit/commit/d9e61bbb56beb116a6f42f89a97f6ed0adbbb8c0
Author: Said Abou-Hallawa <said at apple.com>
Date: 2023-01-04 (Wed, 04 Jan 2023)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
A Source/WebCore/PAL/pal/spi/mac/NSSearchFieldCellSPI.h
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/ControlStates.h
M Source/WebCore/platform/graphics/controls/ControlFactory.h
A Source/WebCore/platform/graphics/controls/SearchFieldCancelButtonPart.h
A Source/WebCore/platform/graphics/controls/SearchFieldPart.h
M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h
M Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm
M Source/WebCore/platform/graphics/mac/controls/ControlMac.mm
A Source/WebCore/platform/graphics/mac/controls/SearchControlMac.h
A Source/WebCore/platform/graphics/mac/controls/SearchControlMac.mm
A Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.h
A Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.mm
A Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.h
A Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.mm
M Source/WebCore/platform/graphics/mac/controls/TextFieldMac.mm
M Source/WebCore/platform/mac/ThemeMac.mm
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/RenderThemeMac.h
M Source/WebCore/rendering/RenderThemeMac.mm
M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
Log Message:
-----------
[GPU Process] [FormControls] Add ControlParts for SearchField and SearchFieldCancelButton
https://bugs.webkit.org/show_bug.cgi?id=249890
rdar://103703733
Reviewed by Aditya Keerthi.
These ControlParts will handle drawing the SearchField form control and its cancel
button (i.e. `<input type="search">`). For macOS, AppKit will be used to draw the
platform controls.
* Source/WebCore/Headers.cmake:
* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/spi/mac/NSSearchFieldCellSPI.h: Added.
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/ControlStates.h:
* Source/WebCore/platform/graphics/controls/ControlFactory.h:
* Source/WebCore/platform/graphics/controls/SearchFieldCancelButtonPart.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/controls/SearchFieldPart.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlFactoryMac.mm:
(WebCore::ControlFactoryMac::searchFieldCell const):
(WebCore::ControlFactoryMac::createPlatformSearchField):
(WebCore::ControlFactoryMac::createPlatformSearchFieldCancelButton):
* Source/WebCore/platform/graphics/mac/controls/ControlMac.h:
* Source/WebCore/platform/graphics/mac/controls/ControlMac.mm:
(WebCore::ControlMac::updateEnabledState):
(WebCore::ControlMac::updateFocusedState):
(WebCore::ControlMac::updatePressedState):
* Source/WebCore/platform/graphics/mac/controls/SearchControlMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/mac/controls/SearchControlMac.mm: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
(WebCore::SearchControlMac::SearchControlMac):
(WebCore::SearchControlMac::updateCellStates):
* Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/mac/controls/SearchFieldCancelButtonMac.mm: Added.
(WebCore::SearchFieldCancelButtonMac::SearchFieldCancelButtonMac):
(WebCore::SearchFieldCancelButtonMac::cellSize const):
(WebCore::SearchFieldCancelButtonMac::rectForBounds const):
(WebCore::SearchFieldCancelButtonMac::updateCellStates):
(WebCore::SearchFieldCancelButtonMac::draw):
* Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.h: Copied from Source/WebCore/platform/graphics/controls/ControlFactory.h.
* Source/WebCore/platform/graphics/mac/controls/SearchFieldMac.mm: Copied from Source/WebCore/platform/graphics/mac/controls/ControlMac.h.
(WebCore::SearchFieldMac::SearchFieldMac):
(WebCore::SearchFieldMac::draw):
* Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::ensuredView):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::createControlPart const):
(WebCore::RenderTheme::extractControlStyleStatesForRenderer const):
(WebCore::RenderTheme::extractControlStyleForRenderer const):
(WebCore::RenderTheme::extractControlStatesForRenderer const):
(WebCore::RenderTheme::isWindowActive const):
(WebCore::RenderTheme::isDefault const):
(WebCore::RenderTheme::isActive const): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
* Source/WebCore/rendering/RenderThemeMac.h:
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::canPaint const):
(WebCore::RenderThemeMac::canCreateControlPartForRenderer const):
(WebCore::RenderThemeMac::updatePressedState):
(WebCore::RenderThemeMac::paintSearchField): Deleted.
(WebCore::RenderThemeMac::paintSearchFieldCancelButton): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ControlPart>::decode):
Canonical link: https://commits.webkit.org/258462@main
More information about the webkit-changes
mailing list