[webkit-changes] [WebKit/WebKit] ea7efa: [JSC] Expose error messages from ShadowRealms to o...

⭐caitp⭐ noreply at github.com
Wed Jan 4 10:43:01 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea7efa2f7f885f2dc5d0dea65d185fb9974cbf58
      https://github.com/WebKit/WebKit/commit/ea7efa2f7f885f2dc5d0dea65d185fb9974cbf58
  Author: Caitlin Potter <caitp at igalia.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M JSTests/stress/shadow-realm-evaluate.js
    M Source/JavaScriptCore/runtime/Error.cpp
    M Source/JavaScriptCore/runtime/Error.h
    M Source/JavaScriptCore/runtime/ShadowRealmPrototype.cpp

  Log Message:
  -----------
  [JSC] Expose error messages from ShadowRealms to outer realm
https://bugs.webkit.org/show_bug.cgi?id=249324

Reviewed by Yusuke Suzuki.

This adds stuff from a yet unmerged spec change from https://github.com/tc39/proposal-shadowrealm/pull/382.

This particular implementation only concerns itself with converting a
primitive exception to a String and using that as the TypeError message,
or else accessing the own "message" property of an object and using
that, which is sufficient to inherit messages from a native Error.

A more robust approach could attempt to load "message" from the
prototype chain, and could incorporate some limited source information
from the source error into the new error message.

Canonical link: https://commits.webkit.org/258438@main




More information about the webkit-changes mailing list