[webkit-changes] [WebKit/WebKit] 07e931: WebKit::LegacyCustomProtocolManager::didReceiveRes...

Commit Queue noreply at github.com
Wed Jan 4 09:12:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 07e9312ccba7cc1c280a7638c4e03030db0aba06
      https://github.com/WebKit/WebKit/commit/07e9312ccba7cc1c280a7638c4e03030db0aba06
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-01-04 (Wed, 04 Jan 2023)

  Changed paths:
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm
    M Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h
    M Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in
    M Source/WebKit/PlatformMac.cmake
    A Source/WebKit/Shared/Cocoa/CacheStoragePolicy.h
    A Source/WebKit/Shared/Cocoa/CacheStoragePolicy.serialization.in
    M Source/WebKit/UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm
    M Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp
    M Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  WebKit::LegacyCustomProtocolManager::didReceiveResponse() should take a specific type for cacheStoragePolicy
https://bugs.webkit.org/show_bug.cgi?id=250006
<rdar://63360220>

Reviewed by Alex Christensen.

Update LegacyCustomProtocolManager::didReceiveResponse() to use
new WebKit::CacheStoragePolicy enum class instead of uint32_t.
Helper methods are used to convert between CacheStoragePolicy
and NSURLCacheStoragePolicy enum values.

* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/PlatformMac.cmake:
- Add CacheStoragePolicy.serialization.in to build files.

* Source/WebKit/NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:
(WebKit::LegacyCustomProtocolManager::didReceiveResponse):
* Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:
(WebKit::LegacyCustomProtocolManager::didReceiveResponse):
* Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in:
- Switch to use WebKit::CacheStoragePolicy.

* Source/WebKit/Shared/Cocoa/CacheStoragePolicy.h: Add.
(WebKit::CacheStoragePolicy):
(WebKit::toNSURLCacheStoragePolicy):
(WebKit::toCacheStoragePolicy):
- Add enum class and conversion functions.

* Source/WebKit/Shared/Cocoa/CacheStoragePolicy.serialization.in: Add.
- Add for IPC.

* Source/WebKit/UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm:
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
* Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp:
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
* Source/WebKit/UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h:
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
- Switch to use WebKit::CacheStoragePolicy.

* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Add CacheStoragePolicy.h and
  CacheStoragePolicy.serialization.in to Xcode project.

Canonical link: https://commits.webkit.org/258433@main




More information about the webkit-changes mailing list