[webkit-changes] [WebKit/WebKit] 30db21: Snapshotting of mainframe and subframe PDFs are bl...

Nikos Mouchtaris noreply at github.com
Tue Jan 3 12:35:10 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30db210558cfc9c0600560297b4b312a1afc8e3a
      https://github.com/WebKit/WebKit/commit/30db210558cfc9c0600560297b4b312a1afc8e3a
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-01-03 (Tue, 03 Jan 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PluginView.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Snapshotting of mainframe and subframe PDFs are blank in UI-side compositing mode
https://bugs.webkit.org/show_bug.cgi?id=249065
rdar://103160251

Reviewed by Simon Fraser.

Use an in process buffer when snapshotting for a frame containing a pdf. For
subframe pdfs, create a WebCore::Image using the underlying data of the
ShareableBitmap (which creates a CGImage using ShareableBitmap data as the
CGDataProviderRef) and draw that into the GraphicsContext displaylist,
which gets the image to the GPU process.

* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotAtSize):

Canonical link: https://commits.webkit.org/258399@main




More information about the webkit-changes mailing list